Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period numbering incorrect in clock #199

Closed
psvenk opened this issue Dec 9, 2020 · 3 comments · Fixed by #242
Closed

Period numbering incorrect in clock #199

psvenk opened this issue Dec 9, 2020 · 3 comments · Fixed by #242
Assignees
Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Milestone

Comments

@psvenk
Copy link
Member

psvenk commented Dec 9, 2020

When a student has a different number of classes on black days than on silver days (particularly when there is an AM block in one but not the other), the period names do not update when switching between black and silver.

@psvenk psvenk added bug Something isn't working good first issue Good for newcomers frontend Suspected problem with frontend (client-side code in public directory) labels Dec 9, 2020
@psvenk psvenk added this to the 2.6.1 milestone Dec 9, 2020
@notrodes notrodes removed the good first issue Good for newcomers label Dec 23, 2020
@notrodes
Copy link
Collaborator

I think this is best left until after the scraper is done.

@psvenk
Copy link
Member Author

psvenk commented Dec 23, 2020

I think this is best left until after the scraper is done.

@notrodes As I noted via the labels, this is a frontend issue. The current scraper used for the schedule is transplanted from the new (REST) scraper, so there is no remaining blocker on the backend.

@psvenk psvenk modified the milestones: 2.7.1, 2.6.2 Dec 23, 2020
@psvenk
Copy link
Member Author

psvenk commented Jan 6, 2021

This bug actually extends to anyone with morning classes — because the index of a period is used to determine which period it is (e.g., the first period is assumed to be Period 1), the period numbering is wrong.

@psvenk psvenk changed the title Bug with different number of classes on black vs. silver days Period numbering incorrect in clock Jan 6, 2021
@psvenk psvenk added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 6, 2021
@jadebuckwalter jadebuckwalter linked a pull request Jan 6, 2021 that will close this issue
@psvenk psvenk removed good first issue Good for newcomers help wanted Extra attention is needed labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants