Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional changes to snackbar #285

Closed
psvenk opened this issue Mar 24, 2021 · 2 comments · Fixed by #354
Closed

Additional changes to snackbar #285

psvenk opened this issue Mar 24, 2021 · 2 comments · Fixed by #354
Assignees
@PoobyMalom
Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Milestone
2.9.1

Comments

@psvenk
Copy link
Member

psvenk commented Mar 24, 2021

Split off from #222 (review).

  • Deleting an assignment or clicking "undo" in the snackbar scrolls up to the top of the page
  • Clicking anywhere on the snackbar other than the "undo" button dismisses the snackbar permanently
  • Make Ctrl+Z more discoverable and make it use Command+Z on macOS
@psvenk psvenk added the frontend Suspected problem with frontend (client-side code in public directory) label Mar 24, 2021
@psvenk psvenk added this to the 2.8.0 milestone Mar 24, 2021
@psvenk psvenk modified the milestones: 2.8.0, 2.8.1 May 7, 2021
@andOrlando
Copy link
Collaborator

I believe the second bullet point should depend on the arguments to the snackbar, and I think @notrodes is touching up on some of the code. If my aspen fixes I can try to fix these after that

@psvenk psvenk modified the milestones: 2.8.2, 2.9.0 Oct 5, 2021
@tektaxi tektaxi modified the milestones: 2.9.0, 2.9.1 Jun 23, 2022
@tektaxi
Copy link
Collaborator

tektaxi commented Nov 17, 2022

in production, the undo button doesn't work correctly, doesn't go away after clicking

@tektaxi tektaxi added the bug Something isn't working label Nov 17, 2022
@PoobyMalom PoobyMalom self-assigned this Nov 17, 2022
@PoobyMalom PoobyMalom linked a pull request Nov 26, 2022 that will close this issue
Fixed snackbar undo bug #354
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PoobyMalom PoobyMalom

Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Milestone
2.9.1
Development

Successfully merging a pull request may close this issue.

Fixed snackbar undo bug Aspine/aspine
4 participants
@tektaxi @psvenk @PoobyMalom @andOrlando