Keep resolving queued imports while there is progress #1415
Conversation
There was a problem hiding this comment.
From #1386
Hmm, what should happen for star imports is that the file becomes converted to a namespace via File#asImportedNamespace, and lookups are then performed against that namespace. Perhaps there's something wrong when such an imported namespace is populated or goes through another layer of exports (in wrong order)?
Ah! Yeah totally, I had a feeling this may be an ordering issue, but I didn't suggest that as again, don't have a complete grasp on how things were working. But glad the fix wasn't too bad, and more that one import needs to wait for others haha! 😄 Also, Hope that I didn't push you to make the fix, was totally happy to do it as well, but as you could tell, I was just very lost haha 😂
@torch2424 Can you confirm that this fixes the issue?
So I can't share the code (yet) for the use case I am using it for, but I can tell you in the library I'm developing for work, it works perfectly! Thanks @dcodeIO ! 😄
And everything looks good, so if you wanted my review, approving! 😄 👍
| @@ -5,3 +5,6 @@ | |||
|
|
|||
| declare const global: Record<string,unknown>; | |||
| declare function require(name: string): unknown; | |||
| declare namespace console { | |||
| function log(...args: unknown[]): void; | |||
There was a problem hiding this comment.
Nice, thanks for adding this for console log debuggers like me 😂
| } | ||
| } | ||
| } | ||
| if (!madeProgress) { |
There was a problem hiding this comment.
Ahhhhh! I had a feeling it may have been an ordering issue where one import had to resolve before others 😄 👍
| @@ -6,3 +6,6 @@ export { | |||
| default, | |||
| default as renamed_default | |||
| } from "./reexport"; | |||
|
|
|||
| import { exportstar } from "./reexport"; | |||
There was a problem hiding this comment.
Thanks for adding a test as well! 👍
|
🎉 This PR is included in version 0.14.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Yooooo thanks for merging / doing this @dcodeIO ! 😄 👍 |
Potentially fixes #1386. Looks like this is an ordering issue where imports depend upon other imports to be resolved first. In the specific case
Instead of giving up early, the algorithm now repeats while it makes progress.
@torch2424 Can you confirm that this fixes the issue?