-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer the right package manager per the environment #1442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
reviewed
Aug 20, 2020
MaxGraey
reviewed
Aug 20, 2020
MaxGraey
reviewed
Aug 20, 2020
MaxGraey
reviewed
Aug 20, 2020
Co-authored-by: Max Graey <maxgraey@gmail.com>
MaxGraey
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dcodeIO
reviewed
Aug 20, 2020
Co-authored-by: Daniel Wirtz <dcode@dcode.io>
dcodeIO
reviewed
Aug 20, 2020
Thanks for setting this up! :) |
🎉 This PR is included in version 0.14.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff improves the user experience when using other package managers than npm, by referencing the right commands. This is important, because as I described in #495 (comment) the package manager install artifacts aren't strictly compatible, especially in the more modern setups.
Fixes #495