Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer the right package manager per the environment #1442

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Aug 20, 2020

  • I've read the contributing guidelines

This diff improves the user experience when using other package managers than npm, by referencing the right commands. This is important, because as I described in #495 (comment) the package manager install artifacts aren't strictly compatible, especially in the more modern setups.

Fixes #495

bin/asinit Outdated Show resolved Hide resolved
bin/asinit Show resolved Hide resolved
bin/asinit Show resolved Hide resolved
bin/asinit Outdated Show resolved Hide resolved
Co-authored-by: Max Graey <maxgraey@gmail.com>
Copy link
Member

@MaxGraey MaxGraey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxGraey MaxGraey requested a review from dcodeIO August 20, 2020 10:13
bin/asinit Outdated Show resolved Hide resolved
Co-authored-by: Daniel Wirtz <dcode@dcode.io>
bin/asinit Outdated Show resolved Hide resolved
@dcodeIO dcodeIO merged commit a6e5da6 into AssemblyScript:master Aug 20, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Aug 20, 2020

Thanks for setting this up! :)

@github-actions
Copy link

🎉 This PR is included in version 0.14.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add yarn option to asinit
3 participants