Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MIN_NORMAL_VALUE and add POSITIVE_INFINITY/NEGATIVE_INFINITY #1443

Merged
merged 10 commits into from
Aug 20, 2020
Merged

fix: MIN_NORMAL_VALUE and add POSITIVE_INFINITY/NEGATIVE_INFINITY #1443

merged 10 commits into from
Aug 20, 2020

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Aug 20, 2020 •
edited
Loading

  • fix MIN_POSITIVE_VALUE -> MIN_NORMAL_VALUE in definitions
  • add (f32|f64).POSITIVE_INFINITY and (f32|f64).NEGATIVE_INFINITY
  • add (f32|f64).NaN fo consistany
  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO August 20, 2020 13:27
dcodeIO
dcodeIO reviewed Aug 20, 2020
View reviewed changes
std/portable/index.js Outdated Show resolved Hide resolved
@MaxGraey MaxGraey requested a review from dcodeIO August 20, 2020 13:36
@MaxGraey MaxGraey changed the title FIx MIN_POSITIVE_VALUE -> MIN_NORMAL_VALUE for definitions fix: MIN_NORMAL_VALUE and add POSITIVE_INFINITY/NEGATIVE_INFINITY Aug 20, 2020
@MaxGraey MaxGraey requested a review from dcodeIO August 20, 2020 14:23
dcodeIO
dcodeIO reviewed Aug 20, 2020
View reviewed changes
std/assembly/builtins.ts Outdated Show resolved Hide resolved
dcodeIO
dcodeIO reviewed Aug 20, 2020
View reviewed changes
std/assembly/builtins.ts Outdated Show resolved Hide resolved
MaxGraey and others added 2 commits August 20, 2020 18:39
@MaxGraey @dcodeIO
Update std/assembly/builtins.ts
3b1d8f8 
Co-authored-by: Daniel Wirtz <dcode@dcode.io>
@MaxGraey @dcodeIO
Update std/assembly/builtins.ts
af43171 
Co-authored-by: Daniel Wirtz <dcode@dcode.io>
@dcodeIO
Copy link
Member

dcodeIO commented Aug 20, 2020

LGTM! We'll also have to update the docs with the new ones :)

@dcodeIO
Copy link
Member

dcodeIO commented Aug 20, 2020

Looks like fixtures need to be updated for the suggestions

@dcodeIO dcodeIO merged commit 6df63c4 into AssemblyScript:master Aug 20, 2020
@MaxGraey MaxGraey deleted the fix-min-normal-values-definitions branch August 20, 2020 16:33
@github-actions
Copy link

🎉 This PR is included in version 0.14.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO