Rtrace shadow memory and instrumentation #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a shadow memory, keeping track of alloc, resize, move and free ranges, and the option to instrument loads and stores to detect OOB accesses.
Doesn't find any problems in our tests, which is good, but hits OOB accesses in the bootstrapped compiler during PureRC's collection phase, indicating that something is off there. Will be helpful to debug, though. Also note that memory instrumentation is extremely slow currently due to having to look at stack traces to tell legit TLSF bookkeeping apart from actual OOB block accesses, but it's a start.