Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Shiden Ethereum block hash fix to upstream #1222

Open
Dinonard opened this issue Apr 5, 2024 · 0 comments
Open

Update Shiden Ethereum block hash fix to upstream #1222

Dinonard opened this issue Apr 5, 2024 · 0 comments
Labels
project Issue is part of an ongoing project

Comments

@Dinonard
Copy link
Member

Dinonard commented Apr 5, 2024 •
edited
Loading

Description

Revert old block hash fix - Shiden block fix with the upstreamed better fix - polkadot-evm/frontier#1044

In general, as part of this task, we should get rid of the custom dirty fix code we use to circumvent the issue.

What is the block hash fix?

Due to some problem with storage migration back in the day, for few blocks (most likely one) there parent hash is lost and when retrieved via RPC results in 0x00..00 (Default::default()).

More context here:

Question/issue in upstream frontier: polkadot-evm/frontier#1534
@Dinonard Dinonard added the project Issue is part of an ongoing project label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project Issue is part of an ongoing project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dinonard