Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Improved benchmark outputs #1285

Open
Dinonard opened this issue Jul 2, 2024 · 0 comments
Open

[CI] Improved benchmark outputs #1285

Dinonard opened this issue Jul 2, 2024 · 0 comments
Labels
project Issue is part of an ongoing project

Comments

@Dinonard
Copy link
Member

Dinonard commented Jul 2, 2024

Description

There are two distinct benchmark outputs we want to generate.

The first one is related for the "standalone" pallet benchmark which should generate WeightInfo trait and define SubstrateWeight struct with impl of the aforementioned trait, as well as default impl on the empty tuple.

The second output type is specific to the runtime where only SubstrateWeight with impl of the already defined trait is needed.

Running benchmarks in our CI should generate both as two separate files.
@Dinonard Dinonard added the project Issue is part of an ongoing project label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project Issue is part of an ongoing project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dinonard