Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the DeepDDI model #2

Closed
benedekrozemberczki opened this issue Dec 15, 2021 · 13 comments · Fixed by #63
Closed

Add the DeepDDI model #2

benedekrozemberczki opened this issue Dec 15, 2021 · 13 comments · Fixed by #63
Labels

Comments

@benedekrozemberczki
Copy link
Contributor

benedekrozemberczki commented Dec 15, 2021

Dear @hzcheney,

  • Please read the paper first. It is here.
  • After that read the contributing guidelines.
  • If there is an existing open source version of the model please take a look.
  • ChemicalX is built on top of PyTorch 1.10. and torchdrug.
  • A similar model is which uses to generate drug representations. Take a look at the layer definition here.
  • The library heavily builds on top on torchdrug and molecules in batches are PackedGraphs.
  • There is already a model class under ./chemicalx/models/
  • Context features, drug level features and labels are all FloatTensors.
  • Look at the examples and tests under ./examples/ and ./tests/.
  • Add auxiliary layers as you see fit - please document these, add tests and add these layers to the main readme.md if needed.
  • Add typing to the initialisation and forward pass.
  • Non data dependent hyperparameters should have default values.
  • Please add tests under ./tests/ and make sure that your model/layer is tested with real data.
  • Write an example under ./examples/. What is the AUC on the test set? Is it reasonable?
@hzcheney
Copy link
Contributor

Hi!😊Is this repo welcome for contribution?

@benedekrozemberczki
Copy link
Contributor Author

Hi @hzcheney,

We are architecting the data loaders in January 2022 and after that, we will have a board with outstanding features and issues. I will get back to you!

Thank you for your interest! We want to hit KDD 2022 Applied Track.

Benedek

@hzcheney
Copy link
Contributor

That will be great! Good luck on your paper!

@benedekrozemberczki
Copy link
Contributor Author

Hi @hzcheney ,

Are you interested in contributing?

@hzcheney
Copy link
Contributor

hzcheney commented Jan 14, 2022

@benedekrozemberczki Yeah, I will try.

@benedekrozemberczki
Copy link
Contributor Author

@yuwvandy what do you think?

@hzcheney
Copy link
Contributor

Hi! @benedekrozemberczki Sorry about the late response, I have already finished the model part. There is a problem with the input feature named SSP(structural similarity profile), it consists of the drug similarity vector which is based on their fingerprint. The problem is I can't find a straightforward way to calculate the SSP, any idea?

@benedekrozemberczki
Copy link
Contributor Author

It is the following:

  1. For each drug a fingerprint is generated D X n. Where D is the number of drugs and n is the fingerprint dimensionality.
  2. Using the fingerprints you define a D X D similarity matrix.
  3. Using this Matrix you use PCA to reduce the dimensionality of the similarity matrix.
  4. This would require on my side that we add a key to the dataset which we could use to retrieve the SSP vectors.

I would say using the drug feature vectors is sufficient to develop this.

@cthoyt
Copy link
Contributor

cthoyt commented Jan 27, 2022

I would say don’t consider the drug featurization as a part of the model. Whether you use maacs, Morgan, or SSP shouldn’t make a difference

@cthoyt
Copy link
Contributor

cthoyt commented Jan 27, 2022

So you could just submit the PR to take in whatever drug features are available from the data loader (currently Morgan fingerprints) and in future work we could add different featurizations to the data loader.

@benedekrozemberczki
Copy link
Contributor Author

Completely agree with @cthoyt about this. It should not be on the model side.

@benedekrozemberczki
Copy link
Contributor Author

@hzcheney Are you going to open a PR with your code?

@hzcheney
Copy link
Contributor

@hzcheney Are you going to open a PR with your code?

@benedekrozemberczki Yeah! I have already opened a PR and please review it!

@cthoyt cthoyt added the model label Feb 1, 2022
@cthoyt cthoyt changed the title Add the DeepDDI model. Add the DeepDDI model Feb 1, 2022
@cthoyt cthoyt mentioned this issue Feb 1, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants