-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the DeepDDI model #2
Comments
Hi!😊Is this repo welcome for contribution? |
Hi @hzcheney, We are architecting the data loaders in January 2022 and after that, we will have a board with outstanding features and issues. I will get back to you! Thank you for your interest! We want to hit KDD 2022 Applied Track. Benedek |
That will be great! Good luck on your paper! |
Hi @hzcheney , Are you interested in contributing? |
@benedekrozemberczki Yeah, I will try. |
@yuwvandy what do you think? |
Hi! @benedekrozemberczki Sorry about the late response, I have already finished the model part. There is a problem with the input feature named SSP(structural similarity profile), it consists of the drug similarity vector which is based on their fingerprint. The problem is I can't find a straightforward way to calculate the SSP, any idea? |
It is the following:
I would say using the drug feature vectors is sufficient to develop this. |
I would say don’t consider the drug featurization as a part of the model. Whether you use maacs, Morgan, or SSP shouldn’t make a difference |
So you could just submit the PR to take in whatever drug features are available from the data loader (currently Morgan fingerprints) and in future work we could add different featurizations to the data loader. |
Completely agree with @cthoyt about this. It should not be on the model side. |
@hzcheney Are you going to open a PR with your code? |
@benedekrozemberczki Yeah! I have already opened a PR and please review it! |
Dear @hzcheney,
which uses
to generate drug representations. Take a look at the layer definition here../chemicalx/models/
./examples/
and./tests/
../tests/
and make sure that your model/layer is tested with real data../examples/
. What is the AUC on the test set? Is it reasonable?The text was updated successfully, but these errors were encountered: