incompatibility with Dynamic Trees and Better Foliage Renewed

[Auden-Clifford]

Describe the bug:
This seems to be a unique compatibility issue with Dynamic Trees, Immersive Weathering & Better Foliage Renewed. The issue only happens when all 3 are installed at once. The issue is that falling leaves and leaf piles are missing their textures. In-game they appear with the pink and black checkerboard texture. Additionally, new types of leaf piles have appeared for each tree. I can see in the creative menu that the standard leaf piles still exist and have working textures, but for some reason, there are also several new leaf pile types with the same names as the standard ones but with missing colors. These missing texture leaf piles are the ones being generated under the trees instead of the correct ones. If placed on the ground some of them will behave normally until the stack reaches the point where it stops being transparent, at which point it will convert to a missing texture cube. Others, however, like the Azalea Leaves will stay bleach white until eventually also turning into missing texture cubes.

Versions:
Minecraft version: 1.19.2
Immersive Weathering version: 1.19.2-1.2.10
Moonlight Lib version: 1.19.2-2.3.6
Forge version: 43.3.0

Other mods:

• Dynamic Trees (1.19.2-1.2.0)
• Better Foliage Renewed (4.0.6)

Logs:
latest.log
launcher_log.txt

To Reproduce:

1. install and enable Immersive Weathering, Dynamic Trees, and Better Foliage Renewed
2. launch the game and look around at trees or attempt to place a leaf pile
3. you will notice the missing textures in the trees and the duplicated leaf piles

Expected behavior:
The falling leaves in the trees should have textures and the leaf piles should not be duplicated

Screenshots:

[WhyAreLess]

Yep it's caused by "Better Foliage - Renewed".

You can replace it with "Motschen's Better Leaves" resource pack instead and the issue won't be there anymore

[JoyfulKoinu]

placing the following information somewhere on the mod page would be much appreciated, as I had to scour the internet to determine what incompatibility (I regret not checking issues first) was causing this, at the very least linking useful compatibility resource packs for various mods would be much appreciated somewhere on the posted mod pages on curseforge/other platforms.

[Lictor000]

This happens also with other modded leaves, for example from Biomes O Plenty (mod version 17.1.2.544).
I posted some details also on the Better Folaige issue tracker (eerussianguy/Better-Foliage#18).

Mod versions same as OP except Moonlight Lib is 2.3.7.

[SiverDX]

This is likely due to Better Foliage replacing how the model for leaves look like, causing the fall-back texture (oak leaves) to no longer work (textures is no longer present and I'm assuming that is what moonlight api is going through when searching for relevant textures)

https://github.com/eerussianguy/Better-Foliage/blob/1.21.x/src/main/resources/assets/minecraft/models/block/acacia_leaves.json

Immersive Weathering could maybe add a dummy block with fallback textures themselves which would be untouched by resource packs and other mods

[JoyfulKoinu]

I'd like to note that this is present through a variety of versions, as this issue is present on 1.20.1, as that is the version of the mod I was running when I ran into this issue, so the 1.19.2 label is not completely accurate here.