Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientDynamicResourcesHandler autogenerates based off of bark, even for modded woods that should have scales instead #408

Open
f-raZ0R opened this issue Oct 25, 2024 · 0 comments

Comments

@f-raZ0R
Copy link

f-raZ0R commented Oct 25, 2024

Describe the bug:
The code for autogenerating bark items seems to... not actually do anything differently besides changing the item's id? So despite correctly going "yeah this is Mushroom, this should be scales instead", IW will still go through the steps of... making it a bark.


right here, for example, there is no check for "hey wait these are scales instead! we shouldn't be basing this off of oak bark!"

Here is an image of a "bark".
2024-10-21_11 41 08

Other mods:
N/A,
Logs:
N/A, this is simply due to there not being any code to account for autogenerated scales in ClientDynamicResourcesHandler. The source of the bug is already known.

To Reproduce:

  1. Have IW, and any other mod that adds a woodtype that returns false for type.canBurn()
  2. Look at the very much not scaly bark, that still says "scales" with F3+H

Expected behavior:
These autogenerated scales would be based off of the scales sprite instead of the bark sprite, and have "Scales" in their name instead of Bark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant