New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use less SPICE functions #106

Open

hyrodium opened this issue Dec 2, 2023 · 0 comments

Member

hyrodium commented Dec 2, 2023

This line

AsteroidThermoPhysicalModels.jl/test/TPM_Ryugu.jl

Line 42 in b7cd460

P = SPICE.convrt(7.63262, "hours", "seconds") # Rotation period of Ryugu

can be replaced with Unitful features.

julia> using SPICE, Unitful

julia> P = SPICE.convrt(7.63262, "hours", "seconds")
27477.432

julia> uconvert(u"s", 7.63262u"hr")
27477.432 s

julia> convert(Float64, (7.63262u"hr") / (1u"s"))
27477.432

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment