-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Retrofit http client supplier npe fix (#1617)
* Lombok update to 1.18.6 * Fixed NPE when http client supplier was specied and http client was not. This patch addresses issue that resulted in NPE if http client supplier was specified in `Call.Factory` builder and concrete http client was not, because `getHttpClient()` method was not invoked while constructing retrofit `Call` instance. New, obviously less error prone approach is that http client supplier gets constructed behind the scenes even if user specifies concrete http client instance at call factory creation time and http client supplier is being used exclusively also by `Call` instance. This way there are no hard references to http client instance dangling around in case some component creates a `Call` instance and never issues `newCall()` on it. Fixes #1616.
- Loading branch information
Showing
5 changed files
with
120 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters