Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling cookie jar #1714

Closed
ngbinh opened this issue Apr 8, 2020 · 2 comments
Closed

Allow disabling cookie jar #1714

ngbinh opened this issue Apr 8, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@ngbinh
Copy link

ngbinh commented Apr 8, 2020

since d4f1e58 ,I cannot disable CookieStore by new DefaultAsyncHttpClientConfig.Builder() .setCookieStore(null) ... .build(). There are many usecases where we do not want ahc to handle Cookies.

I am wondering if there should be a more official way of disabling cookie or at least adding a null check here

final int cookieStoreCount = config.getCookieStore().incrementAndGet();

@slandelle
Copy link
Contributor

A regression indeed, thanks for reporting.

@slandelle slandelle self-assigned this Apr 8, 2020
@slandelle slandelle added this to the 2.12.1 milestone Apr 8, 2020
@ngbinh
Copy link
Author

ngbinh commented Apr 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants