Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White on white #8

Open
ejiektpobehuk opened this issue Jun 6, 2024 · 4 comments
Open

White on white #8

ejiektpobehuk opened this issue Jun 6, 2024 · 4 comments

Comments

@ejiektpobehuk
Copy link

image

Not sure if it's the right place, but it's the best I've found.

Image at the top of a README file used at the GitHub Athena group uses white text withoun any backround, shadow or any other trick to make white visible on white.

For example, https://github.com/ejiek/nomcup is a dead project but it has a logo that is visible in both dark and light GitHub modes.

If you don't want to support light theme, it would be cool to have a text in color of Dark theme background to motivate user to use a dark theme. It's not visible for users of the dark theme but guides light theme users.

@D3vil0p3r
Copy link
Member

D3vil0p3r commented Jun 6, 2024

Mmm I like this kind of issue tickets. You are right. I usually use dark themes, but surrounding the white elements by a black boundary could be a good approach.

I will take care of it in a timely manner.

@D3vil0p3r
Copy link
Member

@ejiektpobehuk
Copy link
Author

image
image

Wow! That was a quick response! Thanks!

It's definetely an improvement for the light theme. Not so sure about the dark one.

Right now for both dark and light themes it seems that letters are on two different levels because of the "highlight/outline". Probably it's going to look better if all the letters had the same styled borders.

For the light theme I'd say that many details in the A are still lost and owls outline look too agressive. The owl part is true for the dark theme too.

@D3vil0p3r
Copy link
Member

So do I need just to remove the outer white?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants