Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve failure message if port is in use #236

Open
TristanDebrunner opened this issue Dec 18, 2023 · 0 comments
Open

Improve failure message if port is in use #236

TristanDebrunner opened this issue Dec 18, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
v0.3.1

Comments

@TristanDebrunner
Copy link
Collaborator

If one of the listening ports (JSON or Binary) is already in use, the refbox app emits a panic message in the logs that doesn't specify which port was already in use.

Rather than a panic that gets logged by log_panics we should have a error!() message that includes which port was in use, and a graceful termination of that tokio::task
@TristanDebrunner TristanDebrunner added the enhancement New feature or request label Dec 18, 2023
@TristanDebrunner TristanDebrunner added this to the v0.1.6 milestone Dec 18, 2023
@TristanDebrunner TristanDebrunner changed the title Improve failure message if port is occupied Improve failure message if port is in use Dec 18, 2023
@TristanDebrunner TristanDebrunner modified the milestones: v0.3.0, v0.3.1 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.1
Development

No branches or pull requests
1 participant
@TristanDebrunner