Optimise the hasChanged logic, UpdateProperty, and refine the new records detection in DiffService.

[qifeng-bai]

In most cases, updateProperty is called first to update values such as counts or the ID of the latest records. For doing this, the findNewRecords method or similar logic in DiffService is called . However, the “findNewRecords or similar logic” is in different methods with similar functionality (TBC).

Subsequently, the hasChanged method uses the properties updated by updateProperty to determine if there are any changes.

When an alert is triggered, the hasChanged method is called again, and if it evaluates to true, findNewRecords in DiffService is invoked once more.

This approach results in findNewRecords (or its equivalents) being called multiple times. The sequence of these steps is inefficient, redundant, and unsafe, increasing complexity in building test cases.

Proposed Solution:

findNewRecords should be called first. The reasoning is simple: if there are new records, hasChanged should return true. Afterward, if necessary, UpdateProperty can be executed at the end of findNewRecords.