Linter applies on text.html.ruby

[project0]

for some reason, the plugin tries to lint HTML Ruby ERB files.

[MartinodF]

Same here. The ruby parts of an "HTML (Ruby - ERB)" file (those between <% and %>) are detected as 'source.ruby` and I'm guessing that triggers the plugin to lint the entire file.

Atom 1.0.7
linter 1.4.3
linter-ruby 1.0.2
ruby 2.2.2p95 on Arch Linux

[project0]

editor = atom.workspace.getActiveTextEditor()
editor.scopeDescriptorForBufferPosition(editor.getCursorBufferPosition()).scopes
["text.html.erb", "meta.embedded.line.erb", "source.ruby", "keyword.control.ruby"]

grammar is detect as source.ruby. I guess the problem is related to language-ruby plugin.
Btw. i fixed that by installing the plugin "language-ruby-on-rails"

[philipgiuliani]

Could you port this also to https://github.com/AtomLinter/linter-rubocop ? We have the same problem there for .html.erb files :(

[Arcanemagus]

@philipgiuliani The "fix" in #37 just adds a configuration option to disable certain file extensions.

The proper fix for this would be for whatever package is providing your Ruby language support to properly mark the Ruby code in these files as source.embedded.ruby instead of source.ruby. Once that is fixed these linters will stop triggering on the embedded code (unless they mark themselves as supporting it).

I would imagine your problem lies in this file, which would be why installing language-ruby-on-rails might fix it (as it might have an overriding specification?).

[emilyaviva]

Installing language-ruby-on-rails does not fix the problem. The "fix" in #37, as @Arcanemagus pointed out above, doesn't actually address the problem. I don't want to ignore .html.erb files; on the contrary, they're the ones I want to lint!

[Arcanemagus]

@emilyaviva I'm not quite sure what you mean there... this linter simply runs ruby -w -c on the file and reports the results. From what I understand at least .erb files need to be ran through erb, not ruby.

The whole issue here is that the language-ruby package is mistakenly showing the embedded Ruby code in the .erb files as source.ruby instead of source.embedded.ruby, so this linter thinks that ruby -wc would know how to handle it and attempts to run it on the file.

[emilyaviva]

No, you're right, I had misapprehended how this works. Pay me no heed.