Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Doesn't Lint #45

Closed
bobrocke opened this issue Jun 3, 2015 · 27 comments
Closed

Doesn't Lint #45

bobrocke opened this issue Jun 3, 2015 · 27 comments
Labels

Comments

@bobrocke
Copy link

bobrocke commented Jun 3, 2015

I don't get any errors thrown, nor do I get any linting. I'm not even sure where to look, now. I used to get errors about not finding scss-lint, but those have cleared up.

How can I tell why no linting is happening to .scss files?

@podo
Copy link

podo commented Jun 3, 2015

Same here. Seems started to happen after recent Atom update.

@polybuildr
Copy link

+1

@bobrocke
Copy link
Author

bobrocke commented Jun 3, 2015

OK, while troubleshooting another problem I found I have a /Users/bob/.rvm/gems/ruby-2.0.0-p247 that is a broken sym-link. When I re-pointed it to /Users/bob/.rvm/gems/ruby-2.0.0-p247@rails3, scss-lint began working.

Maybe you guys have that problem, too?

@aniss
Copy link

aniss commented Jun 5, 2015

XML formatter was deprecated from scss-lint that's why https://github.com/brigade/scss-lint/releases/tag/v0.39.0

@dsandstrom
Copy link

XML formatter was deprecated from scss-lint that's why https://github.com/brigade/scss-lint/releases/tag/v0.39.0

There's the Checkstyle formatter that returns XML, but it adds a gem depedency and didn't fix things for me. It would be smarter to use the JSON formatter instead.

@FalkoJoseph
Copy link

Yeah, scss-lint stopped working for me as well. Hope this gets fixed.

@bobrocke
Copy link
Author

Check this issue for something that fixed it for me: #39

@benschell
Copy link

Just a +1 on this; using the latest version of scss-lint makes this package not work due to the change indicated by @aniss . A workaround for now is to remove the old version (gem uninstall scss_lint) and install the older version (gem install scss_lint -v 0.38.0).

@dsandstrom
Copy link

Thanks @benschell. However, what got it working again, for me, was running gem install scss-lint -v 0.38.0 (the dash version of the gem name). The underscore version does not work.

Side note, I mentioned that the JSON formatter should be used instead. There is an open PR that already fixes this. @hd-deman Are you able to work on this package?

Edit: Nevermind, using the old version of the gem doesn't work in Atom v0.210. I get The linter binary 'scss-lint' cannot be found. error.

Edit 2: See #39 for a current fix.

@FalkoJoseph
Copy link

#42 works for me.

@brunowego
Copy link

+1


#42 works!

@anguspiv anguspiv mentioned this issue Jun 25, 2015
@anguspiv
Copy link

So I think I have a potential quickfix using the checkstyle plugin for scsslint, and also using a fix for the scss-lint binary path issue. Though, since there is no spec I am going to spend a day or two kicking the tires before submitting my pull request. But feel free to test my fork please https://github.com/AtomLinter/linter-scss-lint

@dsandstrom
Copy link

@anguspiv #42 doesn't work for you? The checkstyle formatter will add a gem dependency, JSON is the way to go.

@anguspiv
Copy link

Hmm, didn't notice #42 till now, I'll give that a try. I would agree JSON would be the way to go.

@iam4x
Copy link
Member

iam4x commented Jun 26, 2015

Is the new release with #42 is working for you guys?

@polybuildr
Copy link

Isn't working for me right now, at least. :/ But I only tested it today, after getting the new release, so I don't know if I've done this right.

@sergejmueller
Copy link

The 1.0.5 release is not working.

@calderas
Copy link

Not working for me:

"name": "linter-scss-lint",
"version": "1.0.5",
scss-lint 0.39.0

@dsandstrom
Copy link

It wasn't working at first, it was showing one error on the the top of the page. However, I was messing around with linter and gem versions and got it to work. I'm not exactly sure what the fix was, but try:

gem uninstall scss-lint
gem uninstall scss_lint
gem install scss_lint

I'm using the latest linter and gem:

linter@1.1.0
linter-scss-lint@1.0.5
scss_lint (0.39.0)

@calderas
Copy link

confirmed, that worked for me as well

gem uninstall scss-lint
gem uninstall scss_lint

gem install scss_lint
apm install linter
apm install linter-scss-lint

update .atom/config.cson

"linter-scss-lint":
  executablePath: "~/.rbenv/shims/scss-lint"

@davegomez
Copy link

The @calderas is not working for me.

Does anyone gonna fix this?

@hd-deman
Copy link
Member

hd-deman commented Jul 5, 2015

@davegomez try to run
which scss-lint
and use result as executablePath in config.

@iam4x
Copy link
Member

iam4x commented Jul 5, 2015

@davegomez It's hard to fix an issue which we can't reproduce. Ruby has too many configurations possible (rvbenv, rvm, plain ruby) it differs with systems too.

@steelbrain steelbrain added the bug label Jul 5, 2015
@davegomez
Copy link

The executable path is working, it doesn't matter if it takes it automatically or if you set the complete path manually. The issue is present with the latest version of the linter since you can use an older version and it works fine.

I already try to read the code to see if I could figure it out, but I'm not a CoffeeScript developer and can't understand very well how the atom packages work.

By the way, the linter launch a message about an unknown error at line one, so I suspect it could be a file parsing error or something like that.

@quicoto
Copy link

quicoto commented Jul 9, 2015

Running the latest version of the linter (1.0.5) and Atom (1.0.2)

It throws two errors:

“The linter binary 'scss-lint' cannot be found.
Linting has been halted. Please install the linter binary or disable the linter plugin depending on it. Make sure to reload Atom to detect changes”

“Failed to spawn command scss-lint. Make sure scss-lint is installed and on your PATH”

Thank you.

@Fequois
Copy link

Fequois commented Jul 9, 2015

@quicoto That's not a bug, that's an error message. You can resolve your issue by installing the scss_lint gem, or if already installed, manually enter its path in the 'linter-scss-lint' config.

@steelbrain
Copy link
Contributor

Fixed by #58

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests