You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hakunator.pm6 content: I am not too sure about a few of the words in your lists; 'shinny' is not an adverb, it is a verb. Probably should be shiny. 'hushy' seems to be a slang term. 'hola' is not a noun.
hakunator.pm6 code: Not too bad. A little verbose perhaps. Certainly not taking advantage of many Perl 6 idioms. Take a look at https://gist.github.com/thundergnat/fa1dcae2393c89120c4f for how I would have written it. (Feel free to use or ignore any/all of the changes I made)
In 010-use.t: (\N** 4 ) is looking for any 4 characters that aren't newlines. Probably want (\xdigit ** 4 ) instead. ( 4 hexadecimal digits).
([<[a..z]><[a..z]>+]) may be better written as (<[a..z]> ** 2 .. ) or just <[a..z]> * 2 .. * if you aren't using the matches for anything.
There isn't any \n added in the haikunate routine so it is pointless to check for optional newlines. '\n?'
Other than that, not too bad. Thanks for contributing! »ö« :-)
The text was updated successfully, but these errors were encountered:
Wow, your code looks way cleaner. I will definitely update my code with your version.
In terms of Regex you are right. I just put this together yesterday and I had to get the hang out of it.
hakunator.pm6 content: I am not too sure about a few of the words in your lists; 'shinny' is not an adverb, it is a verb. Probably should be shiny. 'hushy' seems to be a slang term. 'hola' is not a noun.
hakunator.pm6 code: Not too bad. A little verbose perhaps. Certainly not taking advantage of many Perl 6 idioms. Take a look at https://gist.github.com/thundergnat/fa1dcae2393c89120c4f for how I would have written it. (Feel free to use or ignore any/all of the changes I made)
In 010-use.t: (\N** 4 ) is looking for any 4 characters that aren't newlines. Probably want (\xdigit ** 4 ) instead. ( 4 hexadecimal digits).
([<[a..z]><[a..z]>+]) may be better written as (<[a..z]> ** 2 .. ) or just <[a..z]> * 2 .. * if you aren't using the matches for anything.
There isn't any \n added in the haikunate routine so it is pointless to check for optional newlines. '\n?'
Other than that, not too bad. Thanks for contributing! »ö« :-)
The text was updated successfully, but these errors were encountered: