Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codable Conformance #49

Open
maksutovic opened this issue Dec 18, 2024 · 0 comments
Open

Codable Conformance #49

maksutovic opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@maksutovic
Copy link
Collaborator

          @maksutovic @aure since we're taking a look at this PR I just wanted to keep applying pressure on Codable here.

The raw value of our ChordType is a String. If you were to change the name of a ChordType enum case in the future then you would break the decoding of any encoding of that case that you have previously made.

IMO if we are set on introducing Codable conformances, we should use some stable raw value when we do it - such as explicitly assigning each case to a specific integer value.

Originally posted by @Matt54 in #47 (comment)

I completely agree that coddle conformance needs to happen, I'll work on it this weekend

@maksutovic maksutovic self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant