Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add Disney+ links to movies and TV shows #15

Open
Davianlols6 opened this issue May 21, 2022 · 2 comments
Open

Suggestion: Add Disney+ links to movies and TV shows #15

Davianlols6 opened this issue May 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Davianlols6
Copy link

Davianlols6 commented May 21, 2022

Hi! I think it would be good to also add the Disney+ links to movies and TV shows in "disneyplus_url" field.

For example:

{
  "id":26,
  "title":"Eternals",
  "release_date":"2021-11-05",
  "box_office":"402064929",
  "duration":157,
  "overview":"Marvel Studios' Eternals features an exciting new team of Super Heroes in the Marvel Cinematic Universe, ancient aliens who have been living on Earth in secret for thousands of years. Following the events of Avengers: Endgame, an unexpected tragedy forces them out of the shadows to reunite against mankind's most ancient enemy, The Deviants.",
  "cover_url":"https://raw.githubusercontent.com/AugustoMarcelo/mcuapi/master/covers/the-eternals.jpg",
  "trailer_url":"https://youtu.be/x_me3xsvDgk",
  "disneyplus_url": "https://www.disneyplus.com/movies/eternals/5cmhJAtkt6Jk"
  "directed_by":"Chloé Zhao",
  "phase":4,
  "saga":null,
  "chronology":26,
  "post_credit_scenes":2,
  "imdb_id":"tt9032400",
  "related_movies":[]
}

Also, if there is any way in which I can help contribute to update the data on the API, I would be more than happy to help :)

@AugustoMarcelo
Copy link
Owner

AugustoMarcelo commented May 21, 2022

Hi, @Davianlols6!

Thanks for the suggestion! It's a good suggestion. I will think about how to put this in a more generic way since this could change tomorrow, e.g., and the movie may no longer be available on Disney+. In addition, I intend to change the cover_url and trailer_url to be both an array of links, so the disneyplus_url could be better added as an object with streaming places where we could find the movie/tv show. Do you understand?

About how to help, for now, I don't have a page where I can make the changes to there, so I just change my seed file and update the database. I have plans to work on an area where anyone could create an account, make changes in the data and submit it to me for approval.

@AugustoMarcelo AugustoMarcelo added the enhancement New feature or request label May 21, 2022
@Davianlols6
Copy link
Author

Yeah sure! That will work as well! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants