Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how the edit icon overlays with the content blocks and improve padding #18

Open
stellarmagnet opened this issue Jun 3, 2019 · 2 comments
Open

Improve how the edit icon overlays with the content blocks and improve padding #18

stellarmagnet opened this issue Jun 3, 2019 · 2 comments
Assignees
@chadoh
Milestone
Sprint 19.14

Comments

@stellarmagnet
Copy link
Contributor

For each content block, the padding should be 24px (TRBL). Inside this should be the content region for the markdown.

Hence we need to update the Edit/pencil icon to overlay on top.

Please refer to this mockup. Padding is shown in purple.

image
@stellarmagnet stellarmagnet added this to the Sprint 19.14 milestone Jun 3, 2019
@chadoh chadoh mentioned this issue Jun 6, 2019
Merged
@stellarmagnet
Copy link
Contributor Author

It looks like these changes may not be in the dev branch? or we are missing some --> the padding and stuff seems off.

@stellarmagnet
Copy link
Contributor Author

@ottodevs the pencil seems fine but the padding is incorrect.

The padding should be 24px, right now it's 30px. I'm sure this is an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadoh chadoh

Labels
None yet
Projects
None yet
Milestone
Sprint 19.14
Development

No branches or pull requests
2 participants
@chadoh @stellarmagnet