-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Every import from "@tps/test-helpers/contracts" should be replaced to "@aragon/os/contracts" #588
Open
3 tasks done
Labels
housekeeping
General clean-up tasks and things related to making our repo super pretty and easy to use.
Comments
ottodevs
added
the
housekeeping
General clean-up tasks and things related to making our repo super pretty and easy to use.
label
Mar 15, 2019
I started working on this but I found some new issues related to some |
@ottodevs this is the last sprint that we will try to resolve this issue, if it's not completed or you don't think there will be time, let's move it to the icebox and evaluate next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
housekeeping
General clean-up tasks and things related to making our repo super pretty and easy to use.
Background: We used for some time a forked set of
@aragon/os
contracts at@test-helpers
package but not anymore, it seems a good moment to replace those imports to prevent future hard to debug bugs.We should replace any pending import across every app from:
Spoof.sol
orImports.sol
generally found attest/
orcontracts/
folders and subfoldersThe final step should be removing the deprecated contracts files from test-helpers package
IMPORTANT: There are still some contracts being used from test-helpers folder, the StandardsBounties related ones, this should be handled carefully to avoid replacing those imports since @aragon/os does not contain bounties related contracts
The text was updated successfully, but these errors were encountered: