Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken encryption algorithms #369

Closed
3 tasks done
ljacqu opened this issue Dec 20, 2015 · 3 comments
Closed
3 tasks done

Broken encryption algorithms #369

ljacqu opened this issue Dec 20, 2015 · 3 comments
Assignees
@ljacqu
Labels
Type: bug
Milestone
5.2 Release

Comments

@ljacqu
Copy link
Member

ljacqu commented Dec 20, 2015 •
edited
Loading

  • Encryption method WBB4 doesn't work, see WBB4Test. Fix it and un-ignore the test class. The problem is that it's supposed to hash BCrypt twice, but this doesn't happen.
  • Hashes for BCRYPT2Y cannot even be generated – see the test class with a simple test set up that will fail. Fix this and add a test class matching the rest of the hash tests.
  • XENFORO (XF.java) has been deleted. It expected some sort of salt, but when new passwords are hashed, no salt is passed and it throws an error.
@ljacqu ljacqu changed the title WBB4 hash is broken Broken encryption algorithms Dec 20, 2015
@ljacqu ljacqu added this to the 5.2 Relase milestone Dec 20, 2015
@ljacqu ljacqu self-assigned this Jan 9, 2016
@sgdc3
Copy link
Member

sgdc3 commented Apr 30, 2016

@ljacqu Any news about this? xD

@ljacqu
Copy link
Member Author

ljacqu commented May 1, 2016

Stuck on the unchecked one.

@ljacqu
Copy link
Member Author

ljacqu commented May 1, 2016

Moved to #685 so we can keep the other improvements marked as 5.2 :)

@ljacqu ljacqu closed this as completed May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacqu ljacqu

Labels
Type: bug
Milestone
5.2 Release
Development

No branches or pull requests
2 participants
@ljacqu @sgdc3