Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: restructure settings #448

Open
ljacqu opened this issue Jan 17, 2016 · 4 comments
Open

Configuration: restructure settings #448

ljacqu opened this issue Jan 17, 2016 · 4 comments

Comments

@ljacqu
Copy link
Member

ljacqu commented Jan 17, 2016

  • Restructure the settings so that the settings are grouped together more clearly and coherently.
  • Write a migration so that a player's old config can be "converted" to the new one
  • Add an entry to the breaking changes page
@sgdc3
Copy link
Member

sgdc3 commented Jan 18, 2016

pushed a WIP of the new config

@ljacqu
Copy link
Member Author

ljacqu commented Jan 18, 2016

One wish I would personally have would be to move the mysqlColumnSalt option to the data source section, also the group column. I understand that those are optional but I find it confusing that different column configs are 50 lines apart

@sgdc3
Copy link
Member

sgdc3 commented Jan 18, 2016

Yeah, i haven't reach the end of the file, in the meantime do what do you want with it. ;)

@ljacqu
Copy link
Member Author

ljacqu commented Oct 1, 2016

Current state: we did some cleanup inside of config but some similar settings are scattered around, e.g. for registration some stuff is under "registration" and some stuff under "security." Also database stuff vs. hooks stuff, and probably many more things. :)

@sgdc3 sgdc3 removed their assignment May 4, 2017
@sgdc3 sgdc3 changed the title [Dev] Configuration: restructure settings Configuration: restructure settings Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants