You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are temporarily using Settings and NewSetting. The goal is to eventually use only NewSetting.
Before this can be done, we need to be able to write proper YAML in NewSetting. This should be done as much as possible by the methods SnakeYAML offers. Integration test should still work and could be enhanced a little more (e.g. have a value with a backslash, have a value with an apostrophe, have a string list with a multi-line value... Just values that might potentially break)
Right now we check in Settings whether we need to rewrite the config.yml file, if for example a setting is missing or an old setting is present. The task of this issue is to move this logic to the NewSetting class and to have that class decide when we need to rewrite to config.yml.
It should be possible to do it a little more generically with the PropertyMap, e.g. to check if a property is missing.
Test before merging (welcome message, email message, rewrite, handling of missing config file, handling of missing email file, isEmailCorrect, force migration flat -> sqlite, force migration of PLAINTEXT hash algorithm)
The text was updated successfully, but these errors were encountered:
We can once Settings is deleted. I don't think it would make sense to gradually change the code in Settings.
Edit: Now I understand how the description of the issue is kind of misleading: it sounds like we'll just keep "NewSetting" forever called like that. That wasn't the intention. :)
We are temporarily using
Settings
andNewSetting
. The goal is to eventually use onlyNewSetting
.Settings
whether we need to rewrite the config.yml file, if for example a setting is missing or an old setting is present. The task of this issue is to move this logic to the NewSetting class and to have that class decide when we need to rewrite to config.yml.It should be possible to do it a little more generically with the
PropertyMap
, e.g. to check if a property is missing.The text was updated successfully, but these errors were encountered: