-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuthMe with IPB4 #483
Comments
Looks like IPB4 does password hashing differently from IPB3. Could you maybe register a test user with "password" and then tell us the hash that it generated in the database? That way we can test against it if we decide to add IPB4 support to AuthMe. Edit: Found the following snippet while doing some searches function check_ipb4($password, $user)
{
if($user['passwordconvert'] == crypt($password, '$2a$13$'.$user['passwordconvertsalt']))
{
return true;
}
return false;
} from https://raw.githubusercontent.com/mybb/merge-system/feature/loginconvert.php |
Oh, cool, you rock!
maybe you also need to set
so that the hashes generated by AuthMe also follow the |
Thanks for the info. In that case we'll need to take a closer look at it. Note that it generating a different hash doesn't necessarily mean it's wrong, but of course since the forum doesn't accept it, something is wrong. |
I'm afraid I already have a lot of things in AuthMe to take care of so I won't have time to look at this in greater detail. Maybe someone else from the dev team can. |
Hi, I have the same problem. Is anyone working on fixing this? |
@Feerko @Maddeningmorel We are all volunteers in the team, please be patient... |
@Feerko Money is not an incentive for me, but if you have the possibility to have a Skype session together sometime, we could kick some butt ;3 |
Thanks, that's already a great help. The real question is what this |
@Xephi can you help us? ;) |
@sgdc3 Me! It looks like IPB4 uses bcrypt but with a higher cost value. |
@games647 Thanks ;) |
@Feerko Do you use AuthMe for registrations or logins? EDIT: I used your table setup and the login in minecraft works for me. |
That's weird, because the salt is included in the bcrypt hash. It's the first 22 characters after the last $. |
@Feerko Does it work if you copy the salt into the salt column? |
@Feerko: random guess, what if you add a "salt" (random text of same length as the others) into the column? |
If so, the implementation is easy: use BCrypt (with 13 as number of rounds?) + add behavior to persist a random string of fixed length to the column |
@ljacqu So maybe we should save the salt in the salt column although it's not needed. |
This looks like xenforo
|
@Feerko IPB4 support has been implemented by @DNx5 and should work by setting |
Sad that we never got feedback from @Feerko, but I'm assuming that this can be closed. |
Hi, script is working with ipb 4, but there is one problem, script doesn't add default group and user can't log in forum. :) Default group is 3, collum is member_group_id |
Hi @krokit, if you'd like to discuss about this could I ask you to create a new issue? |
No description provided.
The text was updated successfully, but these errors were encountered: