Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AntiBot: find better implementation for users in time span #938

Closed
ljacqu opened this issue Sep 4, 2016 · 2 comments
Closed

AntiBot: find better implementation for users in time span #938

ljacqu opened this issue Sep 4, 2016 · 2 comments
Assignees
Milestone

Comments

@ljacqu
Copy link
Member

ljacqu commented Sep 4, 2016

The AntiBot class checks that in the last 5 seconds not more than x players have joined. This is being solved with threads, so a task with a wait time is scheduled to decrease the counter again. Find a better way of doing this without scheduling threads.

@Platinteufel
Copy link
Contributor

Platinteufel commented Sep 7, 2016

With the current implementation AntiBot can also enable after a server restart, when all players try to rejoin again. Maybe there should be an option that AntiBot only triggers on X unregistered players? I think you don't have to check regular players.
If I get a botattack the probabilty that there are known players is very low, especially if they have names like "gd52heg2hd6u".

@ljacqu
Copy link
Member Author

ljacqu commented Sep 7, 2016

@Platinteufel this is the intended behavior of AntiBot (only fire if X unregistered players are observed). Please open another issue if this is not the case

@DNx5 DNx5 self-assigned this Oct 17, 2016
@ljacqu ljacqu added this to the 5.2 milestone Oct 30, 2016
@ljacqu ljacqu closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants