Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent types for fields shared between subscription and transaction #178

Open
whyayala opened this issue Oct 21, 2020 · 0 comments
Open

Comments

@whyayala
Copy link

whyayala commented Oct 21, 2020

We are looking to add a phone number to our requests to create subscriptions and transactions. I noticed an odd discrepancy between how phone numbers are stored on TransactionRequestType and ARBSubscriptionType.

TransactionRequestType supports phoneNumber on it's billTo field of type CustomerAddressType.

However,

ARBSubscriptionType does not use that same type for it's billTo field. It instead uses NameAndAddressType which does not support a phoneNumber field. It does have a customer field of CustomerType which supports a phoneNumber.

But,

TransactionRequestType's customer field uses CustomerDataType which inexplicably does not have a phoneNumber field.

This is somewhat confusing and inconsistent. I'm not sure if this is by design or something was typed incorrectly.

Since CustomerAddressType extends the NameAndAddressType I would propose changing the ARBSubscriptionType billTo field to CustomerAddressType

or change the customer field on TransactionRequestType from CustomerDataType to CustomerType since the latter supports all of the formers fields as well as adding two new ones.

Appreciate your time.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant