Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is Occlusion-aware Cost Volume implemented? #3

Open
JunjieLiuSWU opened this issue Aug 8, 2022 · 8 comments
Open

Where is Occlusion-aware Cost Volume implemented? #3

JunjieLiuSWU opened this issue Aug 8, 2022 · 8 comments

Comments

@JunjieLiuSWU
Copy link

Hi, Occlusion-aware Cost Volume is proposed in your paper, but I didn't find where it is implemented in the code, could you show me about it?

@fengziyue
Copy link
Member

Hi JunjieLiu:

It is implemented at:

@JunjieLiuSWU
Copy link
Author

Hi JunjieLiu:

It is implemented at:

It sames that dynamic object mask is not used here.

@fengziyue
Copy link
Member

Thank you for pointing out the confusion. I just updated some variable names and comments.

The dynamic object mask is used in the DOMD module. After it, the occluded areas will be black. So in here we assume pixels of RGB value < 0.15 to be occluded.

Here we project the occlusion mask of the image to each layers of the cost volume.

@JunjieLiuSWU
Copy link
Author

`

Thank you for pointing out the confusion. I just updated some variable names and comments.

The dynamic object mask is used in the DOMD module. After it, the occluded areas will be black. So in here we assume pixels of RGB value < 0.15 to be occluded.

Here we project the occlusion mask of the image to each layers of the cost volume.

Thank you for your explanation, but I have another question, I noticed that occluded areas will be set to zeros in the training phase (trainer.py), but It not applied in the inference phase(evaluate_depth.py), that means Occlusion-aware Cost Volume is not used in the inference phase? And why is that?

@fengziyue
Copy link
Member

do you mean here?

@JunjieLiuSWU
Copy link
Author

JunjieLiuSWU commented Aug 10, 2022

do you mean here?

I mean here in the training phase, but there is not the same operation I the inference phase, and dynamic object mask is not used in the inference phase, so how is the DOMD is applied in the inference phase?

@fengziyue
Copy link
Member

Seems the evaluate_depth.py is not the correct version, I'm investigating it. You can use the val() function in the trainer.py now, it also evaluates on the test set.

@JunjieLiuSWU
Copy link
Author

Seems the evaluate_depth.py is not the correct version, I'm investigating it. You can use the val() function in the trainer.py now, it also evaluates on the test set.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants