Skip to content

fix: small bugs #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webdevcody merged 3 commits into from
Jan 6, 2026
Merged

fix: small bugs #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0b3e0d
refactor: move logger initialization outside of useCliStatus function
Shironex Jan 6, 2026
b8e0c18
fix: theme switch bug
Shironex Jan 6, 2026
a4968f7
fix: show success toast only during project creation flow
Shironex Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/ui/src/components/layout/sidebar/hooks/use-spec-regeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,22 @@ export function useSpecRegeneration({
}

if (event.type === 'spec_regeneration_complete') {
// Only show toast if we're in active creation flow (not regular regeneration)
const isCreationFlow = creatingSpecProjectPath !== null;

setSpecCreatingForProject(null);
setShowSetupDialog(false);
setProjectOverview('');
setSetupProjectPath('');
// Clear onboarding state if we came from onboarding
setNewProjectName('');
setNewProjectPath('');
toast.success('App specification created', {
description: 'Your project is now set up and ready to go!',
});

if (isCreationFlow) {
toast.success('App specification created', {
description: 'Your project is now set up and ready to go!',
});
}
} else if (event.type === 'spec_regeneration_error') {
setSpecCreatingForProject(null);
toast.error('Failed to create specification', {
Expand Down
2 changes: 1 addition & 1 deletion apps/ui/src/components/views/setup-view/hooks/use-cli-status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ interface UseCliStatusOptions {
setCliStatus: (status: any) => void;
setAuthStatus: (status: any) => void;
}
const logger = createLogger('CliStatus');

export function useCliStatus({
cliType,
Expand All @@ -15,7 +16,6 @@ export function useCliStatus({
setAuthStatus,
}: UseCliStatusOptions) {
const [isChecking, setIsChecking] = useState(false);
const logger = createLogger('CliStatus');

const checkStatus = useCallback(async () => {
logger.info(`Starting status check for ${cliType}...`);
Expand Down
7 changes: 6 additions & 1 deletion apps/ui/src/components/views/setup-view/steps/theme-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ interface ThemeStepProps {
}

export function ThemeStep({ onNext, onBack }: ThemeStepProps) {
const { theme, setTheme, setPreviewTheme } = useAppStore();
const { theme, setTheme, setPreviewTheme, currentProject, setProjectTheme } = useAppStore();
const [activeTab, setActiveTab] = useState<'dark' | 'light'>('dark');

const handleThemeHover = (themeValue: string) => {
Expand All @@ -24,6 +24,11 @@ export function ThemeStep({ onNext, onBack }: ThemeStepProps) {

const handleThemeClick = (themeValue: string) => {
setTheme(themeValue as typeof theme);
// Also update the current project's theme if one exists
// This ensures the selected theme is visible since getEffectiveTheme() prioritizes project theme
if (currentProject) {
setProjectTheme(currentProject.id, themeValue as typeof theme);
}
setPreviewTheme(null);
};

Expand Down