Add support to specify ShouldMapMethod #2960
Conversation
|
|
src/AutoMapper/TypeDetails.cs
Outdated
| private IEnumerable<MethodInfo> BuildPublicNoArgExtensionMethods(IEnumerable<MethodInfo> sourceExtensionMethodSearch, Func<MethodInfo, bool> shouldMapMethod) | ||
| { | ||
| var explicitExtensionMethods = sourceExtensionMethodSearch.Where(method => method.GetParameters()[0].ParameterType == Type); | ||
| var explicitExtensionMethods = sourceExtensionMethodSearch.Where(shouldMapMethod).Where(method => method.GetParameters()[0].ParameterType == Type); |
There was a problem hiding this comment.
I think we can remove all the filters inside the method and simply filter the input parameter when calling the method.
| namespace AutoMapper.UnitTests | ||
| { | ||
| public class ShouldMapMethod : NonValidatingSpecBase | ||
| { |
There was a problem hiding this comment.
This looks good, but the extension method case needs a test too.
There was a problem hiding this comment.
Ok. I'm gonna add it.
…ling BuildPublicNoArgExtensionMethods
|
Hi @jbogard, did you have a chance to look to this PR? Please let me know if anything is missing. Thanks in advance. |
|
Thank you very much @jbogard. Any chance to launch a pre-release version on nuget that include this change. |
|
@lbargaoanu Thank you. MyGet build worked. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Add support to specify ShouldMapMethod to determine which methods, of those that are eligible to be mapped (parameterless, public, and non-static or extension methods) should be mapped.
Fixed #2959