Skip to content

Reverse the string based MapFrom #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2020
Merged

Reverse the string based MapFrom #3336

merged 4 commits into from
Mar 9, 2020

Conversation

timmi-on-rails
Copy link
Contributor

@timmi-on-rails timmi-on-rails commented Feb 25, 2020 •
edited by lbargaoanu
Loading

  • Added failing tests

Fixes #3329.

@dnfclas
Copy link

dnfclas commented Feb 25, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@timmi-on-rails
Copy link
Contributor Author

Here we go, I am done.
I tryed to keep the changes minimalistic, because I don't understand everything along the way, so I had to rely on a hopefully good test coverage.

Feedback codebase

For me it was hard to follow the code, because the open generic cases are always treated special and this makes the code more complex/nested/partially redundant.
I guess the open generic case should be handled more naturally.
Meaning, we need some abstraction for the LambdaExpression that can handle the open generic case.
A good starting point might be the IPropertyMapConfiguration interface. Maybe the
LamdbaExpression could be replaced by MemberPath.
Haven't thought about deeply though.

@lbargaoanu lbargaoanu added this to the v.next milestone Feb 26, 2020
@lbargaoanu lbargaoanu changed the title Fix reverse mapping Reverse the string based MapFrom Feb 26, 2020
lbargaoanu
lbargaoanu approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@lbargaoanu lbargaoanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic changes. Hopefully I didn't break anything.
Thanks!

@lbargaoanu
Copy link
Contributor

If this fixes the attributes stuff, you might want to add a test for it.

@timmi-on-rails
Copy link
Contributor Author

It doesn't fix attributes, but I can work out a fix and test for that.
Do you want me to put it in this merge request here or separate?

@lbargaoanu
Copy link
Contributor

Separate.

@timmi-on-rails
Copy link
Contributor Author

timmi-on-rails commented Feb 26, 2020 •
edited
Loading

Ok, your changes look good.

@timmi-on-rails timmi-on-rails mentioned this pull request Feb 26, 2020
Merged
@lbargaoanu
Copy link
Contributor

@jbogard Merge?

@jbogard jbogard merged commit bb1c612 into LuckyPennySoftware:master Mar 9, 2020
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbargaoanu lbargaoanu lbargaoanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbogard jbogard

Labels

Improvement

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

Reverse mapping

4 participants

@timmi-on-rails @dnfclas @lbargaoanu @jbogard