EMSUSD-247 - Added an option box for outliner on edit as Maya Data #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AramAzhari-adsk
changed the title
seando-adsk
requested changes
Aug 10, 2023
There was a problem hiding this comment.
@AramAzhari-adsk I think you must have created your branch from an old dev. I have moved UsdContextOps to UsdUfe and split out the Maya specific items into a "lib/mayaUsd/ufe/MayaUsdContextOps.cpp" file. Your changes need to go into that file.
AramAzhari-adsk
force-pushed
the
azharia/EMSUSD-247/Added-OptionBox-For-Outliner-On-Edit-As-Maya
branch
2 times, most recently
from
9a0a586 to
eeded62
Compare
AramAzhari-adsk
force-pushed
the
azharia/EMSUSD-247/Added-OptionBox-For-Outliner-On-Edit-As-Maya
branch
from
eeded62 to
a22793e
Compare
seando-adsk
reviewed
Aug 10, 2023
| const char editAsMayaOptionsCommand[] = "mayaUsdMenu_EditAsMayaDataOptions"; | ||
| MString script; | ||
| script.format("^1s \"^2s\"", editAsMayaOptionsCommand, Ufe::PathString::string(path).c_str()); | ||
| WaitCursor wait; |
There was a problem hiding this comment.
I don't think we need a wait cursor here. You are just opening an option box.
seando-adsk
approved these changes
Aug 10, 2023
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
seando-adsk
deleted the
azharia/EMSUSD-247/Added-OptionBox-For-Outliner-On-Edit-As-Maya
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.