Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does CrashLoggingDataProvider need to exist as a protocol? #221

Open
mokagio opened this issue Aug 31, 2022 · 0 comments
Open

Does CrashLoggingDataProvider need to exist as a protocol? #221

mokagio opened this issue Aug 31, 2022 · 0 comments

Comments

@mokagio
Copy link
Contributor

mokagio commented Aug 31, 2022

While working on #220, I was surprised to see CrashLoggingDataProvider as a protocol when the role it has in the code is that of a value type carrying configuration values.

If there's no external constraint on it being a protocol, I propose to convert it into a struct.

Having it as a struct would mean clients can create an instance directly, without the cruft of implementing a custom type conforming to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant