array use bug

[rogertheriault]

the bot frequently warns about an undefined variable when accessing array attributes

$cat_json_data = [];
		$cat_json_data[] = [
  @wpcomvip-vipgoci-bot
wpcomvip-vipgoci-bot 3 hours ago
❗️ Warning: Variable $cat_json_data is undefined.

and similarly in a foreach loop these false warnings have been seen

[GaryJones]

@rogertheriault Can you please give some more context to this - more code?

[rogertheriault]

Sure, here's a more complete example that should reproduce the issue:

add_filter(
    'blah', function () {
        $variable_name             = [];
        $variable_name['foo']   = 'some-string';
        $variable_name['bar']   = 'another-string';
        return $variable_name;
    }
);

[GaryJones]

The warning is coming from either here or here.

Relevant: #236

@gudmdharalds How much flexibility does the bot have in ignoring certain checks / sniffs?

[gudmdharalds]

@GaryJones: Relatively high. If we want, we can specify that certain sniffs are to be ignored. That should not be complicated to implement.

[GaryJones]

See #236.

[GaryJones]

Now that #449 is completed to use VariableAnalysis proper, I've confirmed that the provided example above doesn't give an error with the develop version of WordPress-VIP-Go, so this is now fixed for VIPCS 2.2.0.