Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to Action #102

Closed
iamtakashi opened this issue Jul 22, 2020 · 3 comments
Closed

Call to Action #102

iamtakashi opened this issue Jul 22, 2020 · 3 comments

Comments

@iamtakashi
Copy link
Contributor

Pattern 112

<!-- wp:group {"align":"full","className":"padding-top-half padding-bottom-half padding-right-half padding-left-half","style":{"color":{"background":"#000000","text":"#ffffff"}}} -->
<div class="wp-block-group alignfull padding-top-half padding-bottom-half padding-right-half padding-left-half has-text-color has-background" style="background-color:#000000;color:#ffffff"><div class="wp-block-group__inner-container"><!-- wp:paragraph {"align":"center","style":{"typography":{"fontSize":17,"lineHeight":"1.42"}}} -->
<p class="has-text-align-center" style="line-height:1.42;font-size:17px">Learn how to generate traffic to your blog in our webinar. <strong><a href="#">L</a></strong><strong><a href="#">e</a></strong><strong><a href="#">a</a></strong><strong><a href="#">r</a></strong><strong><a href="#">n</a></strong><strong><a href="#"> </a></strong><strong><a href="#">m</a></strong><strong><a href="#">o</a></strong><strong><a href="#">r</a></strong><a href="#"><strong>e</strong></a></p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:group -->
@ianstewart
Copy link

👍 . I wonder if this one could use a different viewport width in the inserter. Too small and it won't look like the banner it is. But as wide as it is now I wonder if a bit smaller could be better? I also wonder what other "Banner" patterns we might have in us and want to share?

@iamtakashi
Copy link
Contributor Author

Yeah, we should use a smaller viewport for this. If we go for 960px for this pattern, it'd appear like this in the inserter. Renaming it to "Banner" might help too.

Frame 9

Annoyingly though, the pattern appears a lot taller in the editor than how it'd look on the front of the site because of the baseline margins that Gutenberg add all blocks including nested blocks. The discussion around removing the baseline margins is here.

@alaczek
Copy link
Contributor

alaczek commented May 20, 2021

Closing the loop on that one, as it's already launched.

@alaczek alaczek closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants