-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quotes #74
Comments
If you're not so sure about the quote, I'll remove it and keep it simple :) |
Updated |
Works for me. |
I don't think the block is via Jetpack, but it should be available automatically. What do you see if you search layout grid in the plugin screen in your Atomic test site? Is your atomic site recently setup or it's been for a long time? |
How does the vertical spacing work here? It seems like there's a spacer between the headline and the testimonials? That's probably the right approach since customers can easily change it, but there may be too much default space between the headline and columns. At least, I could see the headline being quite close to the content above it and the testimonials pushed off. Being able to control margins on a group block would be a nice way to ensure that I guess. |
Thanks for asking! This has been bugging me for some time. Here is what's happening with the giant vertical space, and what I'd do as a workaround for now. As a default, without a spacer block between the heading and the column block that houses the testimonials, the margins from the heading and the column block collapse. This is usually fine, but some time like this pattern, we want to have a little more vertical space between the heading and the column block. This is when a spacer block is useful. But, at the moment, spacer block has a minimum of 20px height — i.e. we can't have a spacer block that is 5px height, for example. And when we add a spacer block between the heading and the column block, the margins won't collapse anymore — that creates a big gap. This was what you saw above. -- As a workaround, I'm going to use a custom CSS class Yes, if the pattern is used in non Varia themes or Seedlet, the big gap will appear there, but I think this is the best we can do for now? What do you think? BTW, this is the Gutenberg issue about the minimum height of a spacer block: WordPress/gutenberg#18906 |
Looks like the PR removing the minimum height for a spacer block has merged: WordPress/gutenberg#25528 When this lands in WP.com, I'll update the pattern to remove the custom CSS class so that the spacing will be more or less the same in a wider range of themes. |
That makes perfect sense and I agree it seems like the best short term compromise. Looking forward to wrestling more of this stuff out of the theme's control. |
Background: Automattic/view-design#40
The text was updated successfully, but these errors were encountered: