-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling a private room in single room mode #208
Comments
Could you maybe explain with a screenshot? Why doesn't the text "Want to join it" make sense? |
@akirk I added a screenshot in the top comment. Its because the guest user or even the logged in user, can't just join a private room. They need to be invited. |
Ok understood. In the description there was no mention of the private room and I somehow skipped reading the headline. Can you detect that the room cannot be joined? What about adding exactly what you said: "You need to be invited to be able to join" |
No worries, I was just making a quite note for later. Yeah, some description note based on what type of room this is, we can say something that includes both cases:
|
Related: #181 |
As of now, we show the unknownRoomView, which has the text "Want to join it?" which doesn't make sense.
Should we redirect to login view?
It could be the case user won't have access even after logging in, so should we perhaps present the button to go to login?
We can also add more text to describe the possible outcomes.
The text was updated successfully, but these errors were encountered: