Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling a private room in single room mode #208

Open
ashfame opened this issue Mar 24, 2023 · 5 comments
Open

Handling a private room in single room mode #208

ashfame opened this issue Mar 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ashfame
Copy link
Member

ashfame commented Mar 24, 2023

As of now, we show the unknownRoomView, which has the text "Want to join it?" which doesn't make sense.

Screenshot 2023-03-24 at 11 49 38 AM

Should we redirect to login view?
It could be the case user won't have access even after logging in, so should we perhaps present the button to go to login?
We can also add more text to describe the possible outcomes.

@akirk
Copy link
Member

akirk commented Mar 24, 2023

Could you maybe explain with a screenshot? Why doesn't the text "Want to join it" make sense?

@ashfame
Copy link
Member Author

ashfame commented Mar 24, 2023

@akirk I added a screenshot in the top comment. Its because the guest user or even the logged in user, can't just join a private room. They need to be invited.

@akirk
Copy link
Member

akirk commented Mar 24, 2023

Ok understood. In the description there was no mention of the private room and I somehow skipped reading the headline.

Can you detect that the room cannot be joined? What about adding exactly what you said: "You need to be invited to be able to join"

@ashfame
Copy link
Member Author

ashfame commented Mar 24, 2023

No worries, I was just making a quite note for later. Yeah, some description note based on what type of room this is, we can say something that includes both cases:

  • you need to be invited
  • you need to be logged in (assuming you are already a member of this room)

@ashfame
Copy link
Member Author

ashfame commented Mar 24, 2023

Related: #181

@psrpinto psrpinto added the bug Something isn't working label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants