-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle failure in guest registration #211
Comments
I found another error message than seems to be related to this:
Steps to reproduce:
|
I think this issue manifests itself differently according to whether the user has a session open or not, and also depends on if they have "previously-opened" sessions. That explains why there are different error messages. I think we might need to rework how single-room mode is handled, specifically in what concerns the case where a previous session exists. In this code Here's all the use cases I could think of (can you think of any others?), and what I think the behaviour should be for each:
I think we should rework the code to implement this ^, I would be happy to do so. |
Great. Please proceed on working on this, it's a blocker as we experienced in today's meeting. |
@psrpinto Can you elaborate on what you mean with "session open" here, as I don't understand this branching:
I would add another condition while doing guest login. When its a 403 (meaning guest registrations on server is disabled), we behave as if the room is not world-readable and navigate to login. |
Good catch, I edited my comment to add the condition for when homeserver has guest registration disabled.
By "session open" I mean that the user went past the session picker and is "inside" a session, prior to loading chatrix in single-user mode. (The case where they have a single session is a special case of this, where the session picker isn't displayed, but from a code perspective it's the same, they are "inside" the session even if they don't see the session picker). |
In addition, when I say "previously-opened", I mean they see the session picker with previously used sessions, but they aren't "inside" any session. |
Gotcha, thanks for explaining! The complete branching makes sense now & I think that covers everything 👍 |
Related: #209 |
When a server doesn't have guest account registration enabled, it fails with this error.
It should show unknownRoomView with a login button
The text was updated successfully, but these errors were encountered: