Merge pull request #667 from Automattic/fix/pass-variable-reference

mikeyarce · web-flow · commit 25672a350d04 · 2021-06-14T20:20:06.000-07:00
Fixes non-variable being passed by reference
diff --git a/common/php/screen-options.php b/common/php/screen-options.php
@@ -166,7 +166,8 @@ function ajax_save_callback(){
 		}
 		
 		//The 'action' argument is in the form "save_settings-panel_id"
-		$id = end(explode('-', $_POST['action'], 2));
+		$ids = explode( '-', $_POST['action'], 2 );
+		$id = end( $ids );
 		
 		//Basic security check.
 		check_ajax_referer('save_settings-' . $id, '_wpnonce-' . $id);

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,8 @@ function ajax_save_callback(){`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`//The 'action' argument is in the form "save_settings-panel_id"`
`169`		`- $id = end(explode('-', $_POST['action'], 2));`
	`169`	`+ $ids = explode( '-', $_POST['action'], 2 );`
	`170`	`+ $id = end( $ids );`
`170`	`171`
`171`	`172`	`//Basic security check.`
`172`	`173`	`check_ajax_referer('save_settings-' . $id, '_wpnonce-' . $id);`