Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting peer dependencies #317

Closed
samueljseay opened this issue Apr 18, 2021 · 1 comment
Closed

Conflicting peer dependencies #317

samueljseay opened this issue Apr 18, 2021 · 1 comment

Comments

@samueljseay
Copy link

samueljseay commented Apr 18, 2021 •
edited
Loading

As of npm 7 peer dependencies are installed by default, this brings up a conflict for us in wc-admin with npm 7 between this library and others that use 17.x versions of React.

Is there any downside to extending support of your peer dependencies in this package to cover React 17? I'd be happy to submit a PR to add this if needed.
@noahtallen
Copy link
Contributor

Done in #318, though we still need to publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samueljseay @noahtallen