Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg blocks: use BlockIcon component in MediaPlaceholder #11843

Closed
simison opened this issue Feb 20, 2019 · 1 comment
Closed

Gutenberg blocks: use BlockIcon component in MediaPlaceholder #11843

simison opened this issue Feb 20, 2019 · 1 comment
Assignees
@fgiannar
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug [Type] Janitorial

Comments

@simison
Copy link
Member

simison commented Feb 20, 2019

Use BlockIcon component for custom icons in media-placeholders. Currently, we have some additional CSS to make sure our icons look nice there, but BlockIcon should take care of it for us.

See core doing the same; WordPress/gutenberg#11788

Specifically, these blocks currently use custom icons in MediaPlaceholder or Placeholder:

  • Simple payments
  • Slideshow
  • Tiled gallery

Additionally, possibly replace/extend use of renderMaterialIcon with BlockIcon.
@simison simison changed the title Gutenberg blocks: Gutenberg blocks: use BlockIcon component in MediaPlaceholder Feb 20, 2019
@scruffian scruffian transferred this issue from Automattic/wp-calypso Apr 3, 2019
@scruffian scruffian added [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug [Type] Janitorial [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 3, 2019
@fgiannar fgiannar mentioned this issue Jun 22, 2020
Merged
@jeherve
Copy link
Member

jeherve commented Dec 8, 2021

This has now been fixed.

@jeherve jeherve closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgiannar fgiannar

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@simison @kraftbj @scruffian @jeherve @fgiannar