Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe block placeholder text ("Type your email…") is not translated and cannot be edited #36247

Closed
mrfoxtalbot opened this issue Mar 7, 2024 · 4 comments
Labels
[Block] Subscriptions [Closed] Duplicate Duplicate of an existing issue. [Feature] Grow Blocks Blocks that enhance growth by providing tools for scheduling, communication, and audience expansion. Needs triage Ticket needs to be triaged [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mrfoxtalbot
Copy link

Impacted plugin

Jetpack

Quick summary

The Subscribe block, the Type your email... string is not localized and cannot be edited either.

Screenshot on 2024-03-07 at 05-41-01 (1)

I shared it in p1709786860271869-slack-C02AED43D and @yuliyan mentioned it could be related to how Jetpack registers the blocks and the fact that they don't seem to translate the attribute default values

Might be connected to #15776

Steps to reproduce

  1. Insert the Subscription Block in a non-English site
  2. Notice how there is no way to edit the placeholder text (Type your email…)
  3. Visit the public site and notice how that text is not translated to match the site's locale

A clear and concise description of what you expected to happen.

It should be translateable and, ideally, it should be possible to assign arbitrary text too.

What actually happened

It was not editable or translateable.translatable

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@mrfoxtalbot mrfoxtalbot added [Type] Bug When a feature is broken and / or not performing as intended [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Needs triage Ticket needs to be triaged [Feature] Grow Blocks Blocks that enhance growth by providing tools for scheduling, communication, and audience expansion. labels Mar 7, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Platform] Atomic [Platform] Simple [Pri] High labels Mar 7, 2024
@yuliyan
Copy link
Member

yuliyan commented Mar 7, 2024

On troubleshooting the missing translations, I found that Jetpack uses its own function to register blocks from block.json metadata, which doesn't seem to have a metadata fields translation mechanism, unlike the core registerBlockType function.

That said, I think other Jetpack blocks might also be affected.

Edit: After looking further into this, the blockRegisterType function doesn't seem to translate the attribute fields either.

@pkuliga
Copy link
Contributor

pkuliga commented Mar 7, 2024

Hi, it's possible to edit it from the block Settings tab:

Screenshot 2024-03-07 at 14 30 34

@jeherve
Copy link
Member

jeherve commented Mar 7, 2024

Closing as duplicate of #34916. The problem isn't with the string itself, it is translatable and exists in GlotPress ; the problem is with the display of it in the editor.

Related discussion: pf5801-yJ-p2

@jeherve jeherve closed this as completed Mar 7, 2024
@jeherve jeherve added the [Closed] Duplicate Duplicate of an existing issue. label Mar 7, 2024
@mrfoxtalbot
Copy link
Author

Closing as duplicate of #34916.

I could not find it, thank you @jeherve!

Hi, it's possible to edit it from the block Settings tab:

I could not find it (again 🤣), thank you @pkuliga!

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Closed] Duplicate Duplicate of an existing issue. [Feature] Grow Blocks Blocks that enhance growth by providing tools for scheduling, communication, and audience expansion. Needs triage Ticket needs to be triaged [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

4 participants