Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg v19.6.0-rc.2 Removes getCanvasMode() #39997

Closed
holdercp opened this issue Oct 31, 2024 · 1 comment · Fixed by #40045
Closed

Gutenberg v19.6.0-rc.2 Removes getCanvasMode() #39997

holdercp opened this issue Oct 31, 2024 · 1 comment · Fixed by #40045
Assignees

Comments

@holdercp
Copy link

Impacted plugin

mu wpcom

Quick summary

This is a defect discovered during testing the upcoming Gutenberg 19.6.0 release. It is not live.

The Gutenberg v19.6.0-rc.2 release removes the getCanvasMode() API in WordPress/gutenberg#66213 from the edit-site store. The wpcom-block-editor-nux plugin is using this API and is now unable to load with this GB version installed.

This plugin should be updated to determine the canvas state from the URL params as suggested in the GB PR:

Using the URL for this state is compatible with older GB releases so this can be deployed before v19.6.0 lands.

Related to Automattic/wp-calypso#95960

Steps to reproduce

  1. Install GB v19.6.0-rc.2 on a site
  2. Install a Full Site Edit theme
  3. Navigate to Appearance -> Editor
  4. Check console logs and notice errors relating to the help-center, wpcom-block-editor, and the Jetpack wpcom-block-editor-nux plugins
  5. Click into the canvas to edit
  6. Notice the errors in the UI

A clear and concise description of what you expected to happen.

The mentioned plugins load as normal.

What actually happened

  • Visible UI errors
  • Console errors

Image

Impact

All

Available workarounds?

There is no user impact

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@jeherve
Copy link
Member

jeherve commented Nov 1, 2024

cc @Automattic/lego who worked on bringing the WordPress.com block editor NUX to mu-wpcom a few months ago. Is that something you could look at?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants