Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailchimp Block: Submit Button Set to Large Height #40851

Closed
susanjanec opened this issue Jan 5, 2025 · 9 comments · Fixed by #41790
Closed

Mailchimp Block: Submit Button Set to Large Height #40851

susanjanec opened this issue Jan 5, 2025 · 9 comments · Fixed by #41790
Assignees
Labels
[Block] Mailchimp Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Grow Blocks Blocks that enhance growth by providing tools for scheduling, communication, and audience expansion. [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Auto-allocated [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@susanjanec
Copy link

Impacted plugin

Jetpack

Quick summary

When adding the Mailchimp block, the button to submit the email appears at a tall height when the page is live.

Image

When editing the block the button does appear to look okay.

Steps to reproduce

  1. Add the Mailchimp block to any page.
  2. Edit the button block settings to desired colors
  3. Save Page and view live page
  4. Button on the live page will appear at a tall height.

A clear and concise description of what you expected to happen.

Editing the button block within the Mailchimp block should appear as it does when editing the page when viewing the live page.

What actually happened

No response

Impact

One

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Only tested on Atomic so far as a Mailchimp account is required so could not reproduce on my own test sites. Happening on theme Twenty Twenty Two (Red). Initial customer report in 9243301-zd-a8c.

@susanjanec susanjanec added [Block] Mailchimp [Feature] Grow Blocks Blocks that enhance growth by providing tools for scheduling, communication, and audience expansion. [Platform] Atomic [Type] Bug When a feature is broken and / or not performing as intended Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" Needs triage Ticket needs to be triaged labels Jan 5, 2025
@github-actions github-actions bot added [Status] Escalated to Product Ambassadors [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High labels Jan 5, 2025
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Support References

This comment is automatically generated. Please do not edit it.

  • 9243301-zen

@matticbot matticbot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Jan 5, 2025
@coder-karen
Copy link
Contributor

Related Slack thread: p1736097675310099-slack-C03TY6J1A

It does appear related to Gutenberg changes mentioned in Slack (button height is set to 100%). I haven't been able to replicate though yet, on WoA or self-hosted, modifying various setting on the Mailchimp and inner button blocks, with different themes including Twenty Twenty Two (Red).

@jeherve jeherve added Triaged and removed Needs triage Ticket needs to be triaged labels Jan 6, 2025
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 6, 2025
@susanjanec
Copy link
Author

I just wanted to follow up on this here and to see if we have an update, or even a workaround if there is more time needed to look into this. Thank you!

@coder-karen
Copy link
Contributor

A CSS workaround, if anyone affected is able to add CSS for their site, would be to add:

.wp-block-jetpack-mailchimp .wp-block-button__link {
height: unset;
}

Possibly adding !important after unset (height: unset !important;), if the priority of the CSS isn't high enough. That's based only on testing in the inspector, with the reported site.

No further info at this stage but we will investigate more.

@simison
Copy link
Member

simison commented Jan 8, 2025

Looks similar to what was fixed here:

@coder-karen
Copy link
Contributor

On my test sites the height is actually set to 100% for .wp-block-button__link as well, but the button height issue does not exist.

@Automattic/jetpack-vulcan , is anyone else able to replicate this?

If not, we might need more information from the customer with the issue - can they replicate it on other pages (if they temporarily remove the CSS they now added), can they share more about their the steps they took to add the block, does it only happen with the Twenty Twenty Two (Red) theme for them, could other plugins be interfering.

@monsieur-z
Copy link
Contributor

@coder-karen, I haven't been able to reproduce the issue either (theme: Twenty Twenty Two). I'm not seeing any height property applied to .wp-block-button__link though.

@jordesign
Copy link
Contributor

Lowering the priority of this to normal - as it seems to only affect a single user at this point.

@monsieur-z
Copy link
Contributor

I was able to see the issue on this page: https://berkhistory.org/sign-up-for-email/. Reverting the height: unset fix suggested by the HEs revealed the bug.

The issue is likely caused by this Gutenberg update, which applies a height: 100% CSS rule on the _link element of the button. It seems an appropriate solution to the issue that PR tried to fix, but requires us to update the jetpack/button block to prevent breakage. Setting height: fit-content on the button root element should work, but I'm still wondering if it might create side effects I'm not picturing yet.

The button styles are not loaded in the frontend, so I'll need to look into that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Mailchimp Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Grow Blocks Blocks that enhance growth by providing tools for scheduling, communication, and audience expansion. [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Auto-allocated [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

Successfully merging a pull request may close this issue.

7 participants