Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings UI: initial Stats message still allows to choose weeks or months #7899

Closed
eliorivero opened this issue Sep 29, 2017 · 2 comments · Fixed by #9108
Closed

Settings UI: initial Stats message still allows to choose weeks or months #7899

eliorivero opened this issue Sep 29, 2017 · 2 comments · Fixed by #9108
Assignees
@samhotchkiss @eliorivero
Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] FixTheFlows [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended

Comments

@eliorivero
Copy link
Contributor

On connection, Stats shows a message saying that stats are being collected but the days/weeks/months bar at the top right allows to switch to other date ranges. Maybe this bar should be hidden?

stats
@eliorivero eliorivero added the [Type] Bug When a feature is broken and / or not performing as intended label Sep 29, 2017
@eliorivero eliorivero added this to the 5.4 milestone Sep 29, 2017
@eliorivero eliorivero self-assigned this Sep 29, 2017
@eliorivero eliorivero changed the title Settings UI: issue with stats message Settings UI: initial Stats message still allows to choose weeks or months Sep 29, 2017
@dereksmart dereksmart removed this from the 5.4 milestone Sep 29, 2017
@dereksmart dereksmart added the Admin Page React-powered dashboard under the Jetpack menu label Sep 29, 2017
@dereksmart dereksmart added the [Status] Needs Design Review Design has been added. Needs a review! label Mar 19, 2018
@dmsnell
Copy link
Member

dmsnell commented Mar 21, 2018

Why is this a problem? Won't the weeks/months views also hold the immediate data pouring in on the site?

@eliorivero
Copy link
Contributor Author

It looks like only Days is waiting for data. This placeholder is meant to be displayed when the user first connected the site and there's not Stats data yet. However, right now it looks like if it was missing data for Days only.

@eliorivero eliorivero mentioned this issue Mar 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samhotchkiss samhotchkiss

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] FixTheFlows [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stats: don't display the date range tabs when the initial dialog is shown Automattic/jetpack
5 participants
@beaulebens @samhotchkiss @eliorivero @dmsnell @dereksmart