Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: no option to dismiss Warm Welcome #7904

Closed
jeherve opened this issue Sep 29, 2017 · 4 comments · Fixed by #8697
Closed

Admin Page: no option to dismiss Warm Welcome #7904

jeherve opened this issue Sep 29, 2017 · 4 comments · Fixed by #8697
Assignees
@gravityrail
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Warm Welcome [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Sep 29, 2017

Warm Welcome was added in #7837.

Unfortunately the screen cannot be dismissed. These are the only actions one can take.

screenshot 2017-09-29 at 23 20 12

Could we add an option to dismiss?
@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Sep 29, 2017
@MichaelArestad
Copy link
Contributor

@jeherve There is a dismiss X in the top right (or should be), but I think we can add something more noticeable.

@dereksmart
Copy link
Member

Note that it's the same location as the jumpstart dismiss

@jeherve
Copy link
Member Author

jeherve commented Jan 31, 2018

It took me a minute to find the X in the top right corner of this page, which is almost the same color as the background.

p8oabR-8W-p2

@gravityrail
Copy link
Contributor

Also, clicking esc should close it

@gravityrail gravityrail mentioned this issue Jan 31, 2018
Merged
@gravityrail gravityrail self-assigned this Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gravityrail gravityrail

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Warm Welcome [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable ESC and clicking background to close full screen dialog Automattic/jetpack
4 participants
@gravityrail @jeherve @MichaelArestad @dereksmart