Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notices are still using the old style #8920

Closed
beaulebens opened this issue Feb 23, 2018 · 3 comments
Closed

Notices are still using the old style #8920

beaulebens opened this issue Feb 23, 2018 · 3 comments
Assignees
@MichaelArestad @dereksmart
Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] FixTheFlows [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@beaulebens
Copy link
Member

The notices that we display in Jetpack are still using Calypso's previous visual style, they should be updated:

screen shot 2018-02-22 at 6 32 22 pm
screen shot 2018-02-22 at 6 32 24 pm

vs

screen shot 2018-02-23 at 8 06 19 am
screen shot 2018-02-23 at 8 06 40 am
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu labels Feb 23, 2018
@rickybanister
Copy link

We should be able to copy over the styles part & parcel. Let some design folks know if any assistance is needed.

@MichaelArestad MichaelArestad self-assigned this Mar 1, 2018
@MichaelArestad
Copy link
Contributor

Assigning myself to help assist since I've done this a bunch.

@MichaelArestad
Copy link
Contributor

Note: @shaunandrews has a PR in for a style change on certain inline notices: Automattic/wp-calypso#22924

@dereksmart dereksmart mentioned this issue Mar 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelArestad MichaelArestad

@dereksmart dereksmart

Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] FixTheFlows [Pri] Normal [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@beaulebens @jeherve @rickybanister @MichaelArestad @dereksmart